resource/aws_ses_template: Send only specified attributes for update #3214
Conversation
Addresses an issue where all text-only emails suddenly turned into emails after an update. Currently the `UpdateTemplate` call will set the `HtmlPart` to an empty string if it's not specified for the resource, which results in an email with an empty body in most mail clients.
|
This looks like the right change given what you've described above. Can you verify that if you have both text and html configured, then want to remove one, that simply omitting it from the UpdateTemplate request does the right thing to remove it (e.g. doesn't leave the now omitted one configured on the AWS side)? |
bflad
added
bug
|
I can confirm, that is the case. I tested a build of this branch locally with my Terraform setup, and after the new update went through, the empty HTML part was removed from the template, and my emails appeared properly as plain text again after sending them out. |
There was a problem hiding this comment.
Thanks so much for confirming that! Normally I would ask for an acceptance test to double check this scenario here but I know I was having trouble with eventual consistency issues on update when I initially created the resource. 😢 t.Skipf("Skip due to SES.UpdateTemplate eventual consistency issues")
|
This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Addresses an issue where all text-only emails suddenly turned into emails after an update. Currently the
UpdateTemplatecall will set theHtmlPartto an empty string if it's not specified for the resource, which results in an email with an empty body in most mail clients.